Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Struct binary search (lower_bound/upper_bound) #7865

Merged
merged 28 commits into from
Apr 19, 2021
Merged

Struct binary search (lower_bound/upper_bound) #7865

merged 28 commits into from
Apr 19, 2021

Conversation

ttnghia
Copy link
Contributor

@ttnghia ttnghia commented Apr 5, 2021 •
edited
Loading

This PR add support for lower_bound and upper_bound binary searchs for structs column. This closes #7690.

In addition to adding binary search for structs, I also did some refactoring for tests/search/search_test.cpp, extracting dictionary search test from it. As such, basic search tests, dictionary search tests and (the new) struct search tests are put in separate source files. This is easier to access and future maintainance.

@ttnghia ttnghia added feature request New feature or request 3 - Ready for Review Ready for review by team libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change labels Apr 5, 2021
@ttnghia ttnghia requested a review from a team as a code owner April 5, 2021 22:30
@ttnghia ttnghia requested a review from a team as a code owner April 5, 2021 22:30
@github-actions github-actions bot added the CMake CMake build issue label Apr 5, 2021
@ttnghia ttnghia linked an issue Apr 5, 2021 that may be closed by this pull request
[FEA] Implement lower/upper_bound for struct-typed columns #7690
Closed
jrhemstad
jrhemstad reviewed Apr 5, 2021
View reviewed changes
cpp/src/search/search.cu Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 6, 2021 •
edited
Loading

Codecov Report

Merging #7865 (aaecd5f) into branch-0.20 (51336df) will increase coverage by 0.02%.
The diff coverage is 87.91%.

❗ Current head aaecd5f differs from pull request most recent head 4ba910a. Consider uploading reports for the commit 4ba910a to get more accurate results
Impacted file tree graph

@@               Coverage Diff               @@
##           branch-0.20    #7865      +/-   ##
===============================================
+ Coverage        82.88%   82.91%   +0.02%     
===============================================
  Files              103      103              
  Lines            17668    17655      -13     
===============================================
- Hits             14645    14638       -7     
+ Misses            3023     3017       -6
Impacted Files Coverage Δ
python/cudf/cudf/core/column/__init__.py 100.00% <ø> (ø)
python/cudf/cudf/utils/cudautils.py 57.75% <25.00%> (ø)
python/cudf/cudf/core/column/column.py 88.64% <71.42%> (ø)
python/cudf/cudf/core/column/numerical.py 94.43% <72.72%> (ø)
python/cudf/cudf/core/dataframe.py 90.87% <83.33%> (+0.01%) ⬆️
python/cudf/cudf/utils/utils.py 89.53% <91.66%> (+0.02%) ⬆️
python/cudf/cudf/core/column/datetime.py 89.91% <100.00%> (ø)
python/cudf/cudf/core/column/timedelta.py 88.66% <100.00%> (ø)
python/cudf/cudf/core/groupby/groupby.py 92.28% <100.00%> (+0.83%) ⬆️
python/cudf/cudf/core/index.py 93.07% <100.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8baed5...4ba910a. Read the comment docs.

@github-actions github-actions bot added conda Java Affects Java cuDF API. Python Affects Python cuDF API. labels Apr 6, 2021
@ttnghia
Copy link
Contributor Author

ttnghia commented Apr 7, 2021

Rerun tests.

@gerashegalov gerashegalov mentioned this pull request Apr 7, 2021
Merged
@gerashegalov
Copy link
Contributor

tests in Spark are passing NVIDIA/spark-rapids#2092 (comment)

davidwendt
davidwendt reviewed Apr 8, 2021
View reviewed changes
cpp/src/search/search.cu Outdated Show resolved Hide resolved
@ttnghia ttnghia requested a review from hyperbolic2346 April 12, 2021 13:42
@ttnghia
Copy link
Contributor Author

ttnghia commented Apr 19, 2021

@gpucibot merge

kkraus14
kkraus14 approved these changes Apr 19, 2021
View reviewed changes
Copy link
Collaborator

@kkraus14 kkraus14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmake lgtm

@rapids-bot rapids-bot bot merged commit 1775c3d into rapidsai:branch-0.20 Apr 19, 2021
@ttnghia ttnghia self-assigned this Apr 25, 2021
@ttnghia ttnghia deleted the struct_binary_search branch May 3, 2021 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrhemstad jrhemstad jrhemstad left review comments

@davidwendt davidwendt davidwendt approved these changes

@kkraus14 kkraus14 kkraus14 approved these changes

@hyperbolic2346 hyperbolic2346 hyperbolic2346 approved these changes

@karthikeyann karthikeyann Awaiting requested review from karthikeyann

@rgsl888prabhu rgsl888prabhu Awaiting requested review from rgsl888prabhu

@brandon-b-miller brandon-b-miller Awaiting requested review from brandon-b-miller

Assignees

@ttnghia ttnghia

Labels
3 - Ready for Review Ready for review by team CMake CMake build issue feature request New feature or request libcudf Affects libcudf (C++/CUDA) code. non-breaking Non-breaking change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEA] Implement lower/upper_bound for struct-typed columns
6 participants
@ttnghia @gerashegalov @hyperbolic2346 @kkraus14 @jrhemstad @davidwendt